Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAK4630 LoRaWAN Allow change TCXO control adding it as a parameter #15503

Merged
merged 1 commit into from
Apr 23, 2024
Merged

RAK4630 LoRaWAN Allow change TCXO control adding it as a parameter #15503

merged 1 commit into from
Apr 23, 2024
+5 −1

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Apr 4, 2024 •
edited
Loading

Summary of changes

RAK4630 with Nordic nrf52840 + Semtech SX1262 need change with TCXO voltage, so it's now used as parameter in mbed_app.json as #15312

Documentation

  • Added tcxo_ctrlas a parameter since RAK4630 need default value to be changed from TCXO_CTRL_1_7V to TCXO_CTRL_3_0V (today it was hardcoded)
            "SX126X-lora-driver.tcxo-ctrl": "TCXO_CTRL_3_0V",

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant @0xc0170

@hallard
Allow custom TCXO control parameter
61522fb 
Allow custom TCXO control parameter
@hallard hallard changed the title Allow change TCXO control adding it as a parameter RAK4630 LoRaWAN Allow change TCXO control adding it as a parameter Apr 4, 2024
jeromecoutant
jeromecoutant approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default code doesn't change I think

@hallard
Copy link
Contributor Author

hallard commented Apr 4, 2024

@jeromecoutant yeah, doing nothing (default code) just change nothing, so it should be straightforward and used only if needed

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Apr 10, 2024
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2024

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 12, 2024

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Apr 12, 2024
@mbed-ci
Copy link

mbed-ci commented Apr 23, 2024

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@0xc0170 0xc0170 merged commit 98853ac into ARMmbed:master Apr 23, 2024
18 of 20 checks passed
@mergify mergify bot removed the ready for merge label Apr 23, 2024
@hallard hallard deleted the nordic_rak4630 branch April 25, 2024 08:38
@multiplemonomials multiplemonomials mentioned this pull request Jul 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hallard @0xc0170 @mbed-ci @jeromecoutant